Skip to content

Fix/format#4

Merged
cnjack merged 2 commits intomainfrom
fix/format
Apr 9, 2026
Merged

Fix/format#4
cnjack merged 2 commits intomainfrom
fix/format

Conversation

@cnjack
Copy link
Copy Markdown
Owner

@cnjack cnjack commented Apr 9, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Chores

    • Updated Go toolchain to version 1.25.8
    • Upgraded UI framework dependencies to latest versions

  • Bug Fixes

    • Improved handling of ANSI escape sequences and control characters in output display to prevent visual corruption

cnjack added 2 commits March 31, 2026 19:18
@cnjack
feat: add sanitize function to clean ANSI escape sequences and contro…
58fcdd8 
…l characters in TUI output
@cnjack
refactor: update bubbletea and lipgloss imports to new charm.land paths
6f446b1 
- Changed import paths for bubbletea and lipgloss to the new charm.land versions across multiple files.
- Updated usage of viewport height and width settings to use the new method signatures.
- Refactored the handling of text input and key messages to align with the updated libraries.
- Enhanced the rendering logic to accommodate changes in the new library versions.
@cnjack cnjack merged commit ae0ab29 into main Apr 9, 2026
1 check was pending
@cnjack cnjack deleted the fix/format branch April 9, 2026 15:46
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 9, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d297368b-4bd9-46f8-a789-c114d3bddef7

📥 Commits

Reviewing files that changed from the base of the PR and between 0b078f1 and 6f446b1.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (13)
  • cmd/jcode/main.go
  • cmd/jcode/ssh.go
  • go.mod
  • internal/runner/approval.go
  • internal/runner/runner.go
  • internal/tui/format.go
  • internal/tui/input_views.go
  • internal/tui/pickers.go
  • internal/tui/setup.go
  • internal/tui/ssh_handlers.go
  • internal/tui/statusbar_component.go
  • internal/tui/styles.go
  • internal/tui/tui.go
📝 Walkthrough

Walkthrough

This PR upgrades Charmbracelet UI dependencies from github.com/charmbracelet/ to charm.land/*/v2 module paths across the codebase, updates Go toolchain from 1.24.7 to 1.25.8, and refactors TUI components to use v2 APIs including updated message types, view rendering patterns, and method-based field mutations.

Changes

Cohort / File(s) Summary
Import Migration to charm.land v2
cmd/jcode/main.go, cmd/jcode/ssh.go, internal/runner/approval.go, internal/runner/runner.go, internal/tui/pickers.go, internal/tui/ssh_handlers.go, internal/tui/statusbar_component.go, internal/tui/styles.go		 Updated Bubble Tea, Bubbles, and Lipgloss imports from github.com/charmbracelet/ to charm.land/*/v2 module paths; no logic changes.
TUI Format & Input Handling
internal/tui/format.go, internal/tui/input_views.go		 Added ANSI/control-character sanitization in format.go; updated viewport height assignment from direct field to SetHeight() method in input_views.go; both import v2 modules.
TUI Setup & Configuration
internal/tui/setup.go		 Imported v2 modules; replaced direct textinput width assignments with SetWidth() method calls; changed message type from tea.KeyMsg to tea.KeyPressMsg; updated View() return type from string to tea.View with alt-screen wrapping.
TUI Core & Rendering
internal/tui/tui.go		 Imported v2 modules; refactored View() return type to tea.View; replaced direct viewport dimension assignments with method calls (SetHeight, SetWidth, SetXOffset, SetYOffset); updated message type handling (tea.KeyMsg → tea.KeyPressMsg); added ANSI sanitization for output rendering; changed glamour style from WithAutoStyle() to WithStandardStyle("dark"); updated textarea styling to use Styles() and SetStyles() methods.
Go Module & Toolchain
go.mod		 Updated Go toolchain from 1.24.7 to 1.25.8; migrated Charmbracelet dependencies to v2 module paths (charm.land/*/v2); updated github.com/cloudwego/eino to v0.8.8 and github.com/mark3labs/mcp-go to v0.47.1; refreshed indirect dependency graph with new and removed transitive dependencies.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 Hop, hop, hoorah! The charms now shine,
From legacy paths to v2 divine,
Sanitized views and methods so clean,
The smoothest TUI you've ever seen! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This was referenced Apr 19, 2026
Merged
Merged
Merged
Merged
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cnjack